Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sending items to stash interrupted by items obtained from store #2886

Merged
merged 9 commits into from
Nov 13, 2024
Merged

fix: sending items to stash interrupted by items obtained from store #2886

merged 9 commits into from
Nov 13, 2024

Conversation

luanluciano93
Copy link
Contributor

@luanluciano93 luanluciano93 commented Sep 11, 2024 •
edited
Loading

Description

  • When you send items from a container to the stash, the process is interrupted when there are items obtained from the store.
  • fixed issue with sending items from the loot pouch to the stash

Behaviour

Actual

tibia-knight-teste-2024-09-11-04-22-48_IzmGL5wk.mp4

Expected

fix-stash.mp4

Fixes #1931 and #2331

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Test Configuration:

  • Server Version: Canary Main
  • Client: 13.40
  • Operating System: Windows 11

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@majestyotbr majestyotbr linked an issue Sep 11, 2024 that may be closed by this pull request
Loot Pouch - Stash #2331
Closed
5 tasks
@Chapeleiiro
Copy link
Contributor

Perfect.

phacUFPE
phacUFPE approved these changes Sep 14, 2024
View reviewed changes
Copy link
Contributor

@phacUFPE phacUFPE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working as expected.

murilo09

This comment was marked as outdated.

Sign in to view

murilo09
murilo09 requested changes Oct 14, 2024
View reviewed changes
src/game/game.cpp Outdated Show resolved Hide resolved
@dudantas dudantas changed the title fix: sending items from a container to the stash is interrupted by items obtained from store fix: sending items to stash interrupted by items obtained from store Nov 13, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@dudantas dudantas merged commit 982f184 into opentibiabr:main Nov 13, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murilo09 murilo09 murilo09 approved these changes

@majestyotbr majestyotbr majestyotbr approved these changes

@phacUFPE phacUFPE phacUFPE approved these changes

@Chapeleiiro Chapeleiiro Chapeleiiro approved these changes

@dudantas dudantas dudantas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Canary - Release 3.5
Status: PRs Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loot Pouch - Stash Erro Depot Stash
6 participants
@luanluciano93 @Chapeleiiro @dudantas @phacUFPE @majestyotbr @murilo09